Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-30277 Fix failed docker builds on JFrog #17908

Merged
merged 1 commit into from
Oct 18, 2023
Merged

HPCC-30277 Fix failed docker builds on JFrog #17908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/build-assets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,7 @@ jobs:
build-args: |
PKG_FILE=${{ steps.ln-container.outputs.k8s_pkg_file }}
tags: |
${{ secrets.JFROG_REGISTRY || 'dummy.io' }}/ln/platform-core-${{ matrix.os }}:${{ needs.preamble.outputs.internal_tag }}
${{ secrets.JFROG_REGISTRY || 'dummy.io' }}/ln/platform-core-${{ matrix.os }}:${{ needs.preamble.outputs.candidate_base_branch }}
${{ secrets.JFROG_REGISTRY || 'dummy.io' }}/hpccpl-docker-local/hpcc-platform/${{ matrix.os }}/platform-core-ln:${{ needs.preamble.outputs.internal_tag }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gfortil - I think prior to this change the action failed to push because it was trying to push to the directory 'ln':

ERROR: failed to solve: failed to push ***/ln/platform-core-ubuntu-22.04:internal_9.4.4-rc1: unexpected status from POST request to https://***/v2/ln/platform-core-ubuntu-22.04/blobs/uploads/: 404 Not Found
Error: buildx failed with: ERROR: failed to solve: failed to push ***/ln/platform-core-ubuntu-22.04:internal_9.4.4-rc1: unexpected status from POST request to https://***/v2/ln/platform-core-ubuntu-22.04/blobs/uploads/: 404 Not Found

with this PR change, it will now be trying to push the image inside directory 'hpccpl-docker-local/hpcc-platform/ubuntu-22.04' , is that directory guaranteed to exist, and this new push path succeed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith the hpccpl-docker-local at the beginning is the key to making it work properly. I tested the path Godji supplied earlier this evening and confirmed that it does work. I'll pass you the link on teams.

cache-from: |
type=registry,ref=hpccsystems/platform-core-${{ matrix.os }}:${{ needs.preamble.outputs.candidate_base_branch }}

Expand Down
Loading