Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-30220 ECL Watch fix authentication & ESP session lock issues #17841

Merged

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Sep 28, 2023

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jeclrsg jeclrsg requested a review from GordonSmith September 28, 2023 14:59
@github-actions
Copy link

@jeclrsg jeclrsg force-pushed the hpcc-30220-for-8.10.x branch from 04d4666 to 999c658 Compare September 28, 2023 15:20
Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeclrsg we should discuss, I don't think we should be back porting anything to the React V9 codebase, given it was a tech preview in 8.10.
If there are fixes needed for the Dojo pages, that is fine?

break;
default:
window.location.replace("/esp/files/index.html");
window.location.replace("/");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity checks:

  • Did you test this works when switching between V9 and dojo pages?
  • Does this code match what we have in the 9.2.x branch now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did test that this works as expected when switching versions. But no, it doesn't match what's currently in 9.2. I thought the other PR (#17843) targeting 8.12.x should be merged up into 9.0 and so on. Also, regarding back porting, I believe Stu had pointed out in an ECL Watch meeting that the folks who'd encountered this had only fairly recently moved to 8.10 and they could be there for a while yet.

@GordonSmith
Copy link
Member

@jeclrsg bump

@FernSe01
Copy link

FernSe01 commented Nov 3, 2023

Any plans to have the changes addressed for future merge on 8.10 release? This will benefit Quod client in Brazil.

@GordonSmith GordonSmith merged commit 78d5c95 into hpcc-systems:candidate-8.10.x Nov 9, 2023
22 of 25 checks passed
@jeclrsg jeclrsg deleted the hpcc-30220-for-8.10.x branch June 19, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants