review change

Signed-off-by: Jake Smith <[email protected]>
hpcc-systems · Nov 5, 2024 · d238085 · d238085
1 parent 6a3a023
commit d238085
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/dali/ft/filecopy.cpp b/dali/ft/filecopy.cpp
@@ -1597,13 +1597,12 @@ void FileSprayer::commonUpSlaves()
 
     // noCommon is defaulted to on for non-containerized (revisit!)
     bool noCommon = options->getPropBool(ANnocommon, !isContainerized());
-    if (isContainerized() && noCommon)
+    if (noCommon)
     {
+        if (!isContainerized())
+            return;
         IWARNLOG("Ignoring noCommon option in containerized mode");
-        noCommon = false;
     }
-    else if (noCommon)
-        return;
 
     //First work out which are the same slaves, and then map the partition.
     //Previously it was n^2 in partition, which is fine until you spray 100K files.