review update 2

Signed-off-by: Anthony Fishbeck <[email protected]>
hpcc-systems · Oct 2, 2023 · cf89f71 · cf89f71
1 parent 85f3860
commit cf89f71
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/common/pkgfiles/referencedfilelist.cpp b/common/pkgfiles/referencedfilelist.cpp
@@ -378,12 +378,12 @@ void ReferencedFile::processForeignFileTree(const IPropertyTree *tree, const cha
     }
 }
 
-StringBuffer &makeRemoteLFN(StringBuffer &remoteLfn, const char *remoteStorageName, const char *remotePrefix, const char *lfn)
+static StringBuffer &makeRemoteLFN(StringBuffer &remoteLfn, const char *remoteStorageName, const char *remotePrefix, const char *lfn)
 {
     if (isEmptyString(remoteStorageName))
         return remoteLfn;
     remoteLfn.append("remote::").append(remoteStorageName).append("::");
-    if (remotePrefix && *remotePrefix)
+    if (!isEmptyString(remotePrefix))
         remoteLfn.append(remotePrefix).append("::");
     return remoteLfn.append(lfn);
 }

diff --git a/helm/hpcc/values.schema.json b/helm/hpcc/values.schema.json
@@ -1456,6 +1456,10 @@
         },
         "hpa": {
           "$ref": "#/definitions/hpa"
+        },
+        "expert": {
+          "description": "Custom internal options usually reserved for internal testing",
+          "type": "object"
         }
       }
     },