HPCC-33135 Improve error reporting when pulling roxie stats for graph

Foremost this will improve error reporting when pulling runtime roxie stats, but it will also affect any other ESP methods sending roxie control messages that had an exception return. Look for and propagate roxie control responses that consist of an Exception. Previously exceptions were only propagated when they were children of Endpoint elements in the control message response. Signed-off-by: Terrence Asselin <[email protected]>
hpcc-systems · Jan 10, 2025 · cf7d06f · cf7d06f
1 parent 0bb5480
commit cf7d06f
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/esp/clients/roxiecontrol.cpp b/esp/clients/roxiecontrol.cpp
@@ -38,6 +38,10 @@ static void checkRoxieControlExceptions(IPropertyTree *response)
             me->append(*MakeStringException(ex.getPropInt("Code"), "Endpoint %s: %s", endp.queryProp("@ep"), ex.queryProp("Message")));
         }
     }
+
+    if( strieq("Exception", response->queryName()))
+        me->append(*MakeStringException(response->getPropInt("Code"), "Source %s: %s", response->queryProp("Source"), response->queryProp("Message")));
+
     if (me->ordinality())
         throw me.getClear();
 }