Skip to content

Commit

Permalink
Make some methods, that should not have been public, private in Parqu…
Browse files Browse the repository at this point in the history
…etReader.
  • Loading branch information
jackdelv committed Apr 9, 2024
1 parent e2f29d7 commit 99e8033
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions plugins/parquet/parquetembed.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -764,18 +764,21 @@ class PARQUETEMBED_PLUGIN_API ParquetReader
ParquetReader(const char *option, const char *_location, int _maxRowCountInTable, const char *_partitionFields, const IThorActivityContext *_activityCtx);
ParquetReader(const char *option, const char *_location, int _maxRowCountInTable, const char *_partitionFields, const IThorActivityContext *_activityCtx, const RtlRecord *_expectedRecord);
~ParquetReader();
arrow::Status openReadFile();

arrow::Status processReadFile();
__int64 readColumns(__int64 currTable);
void splitTable(std::shared_ptr<arrow::Table> &table);
bool shouldRead();
__int64 next(TableColumns *&nextTable);
std::shared_ptr<parquet::arrow::RowGroupReader> queryCurrentTable(__int64 currTable);
arrow::Result<std::shared_ptr<arrow::Table>> queryRows();

bool getCursor(MemoryBuffer & cursor);
void setCursor(MemoryBuffer & cursor);

private:
arrow::Status openReadFile();
__int64 readColumns(__int64 currTable);
void splitTable(std::shared_ptr<arrow::Table> &table);
std::shared_ptr<parquet::arrow::RowGroupReader> queryCurrentTable(__int64 currTable);
arrow::Result<std::shared_ptr<arrow::Table>> queryRows();

private:
// Count of processed rows and tables for both partitioned and regular files.
__int64 tablesProcessed = 0; // The number of tables processed when reading parquet files.
Expand Down

0 comments on commit 99e8033

Please sign in to comment.