Reduce outer buffer loop size to avoid scans outside of buffer

hpcc-systems · Sep 19, 2024 · 8c9e06b · 8c9e06b
1 parent a6964f3
commit 8c9e06b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/common/remote/rmtsmtp.cpp b/common/remote/rmtsmtp.cpp
@@ -665,7 +665,7 @@ class CMailInfo
         {
             // Walk the buffer, looking for the STARTTLS option
             char* buffPtr = inbuff;
-            while (buffPtr < (inbuff + inlen))
+            while (buffPtr < (inbuff + inlen - 12)) // 12 == '250 STARTTLS'
             {
                 if (strncmp(buffPtr, "250", 3) == 0)
                 {