Skip to content

Commit

Permalink
Remove inline constructor and change temp container to std::string
Browse files Browse the repository at this point in the history
  • Loading branch information
jackdelv committed Oct 18, 2023
1 parent aeeb64c commit 8486dda
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions plugins/parquet/parquetembed.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,8 @@ __int64 ParquetRowBuilder::getCurrIntValue(const RtlFieldInfo *field)
{
__int64 myint64 = 0;
auto scalar = getCurrView(field);
handleDeserializeOutcome(tokenDeserializer.deserialize(StringBuffer(scalar.size(), scalar.data()).str(), myint64), "signed", scalar.data());
std::string scalarStr(scalar.data(), scalar.size());
handleDeserializeOutcome(tokenDeserializer.deserialize(scalarStr.c_str(), myint64), "signed", scalarStr.c_str());
return myint64;
}
}
Expand Down Expand Up @@ -986,7 +987,8 @@ double ParquetRowBuilder::getCurrRealValue(const RtlFieldInfo *field)
{
double mydouble = 0.0;
auto scalar = getCurrView(field);
handleDeserializeOutcome(tokenDeserializer.deserialize(StringBuffer(scalar.size(), scalar.data()).str(), mydouble), "real", scalar.data());
std::string scalarStr(scalar.data(), scalar.size());
handleDeserializeOutcome(tokenDeserializer.deserialize(scalarStr.c_str(), mydouble), "real", scalarStr.c_str());
return mydouble;
}
}
Expand Down

0 comments on commit 8486dda

Please sign in to comment.