Skip to content

Commit

Permalink
HPCC-32922 Capture lookahead timings for join and keyedjoin activities
Browse files Browse the repository at this point in the history
Signed-off-by: Shamser Ahmed <[email protected]>
  • Loading branch information
shamser committed Nov 12, 2024
1 parent 9d3734f commit 7fd4503
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion thorlcr/activities/join/thjoinslave.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ class JoinSlaveActivity : public CSlaveActivity, implements ILookAheadStopNotify
{
try
{
LookAheadTimer t(slaveTimerStats, timeActivities);
startInput(secondaryInputIndex);

if (ensureStartFTLookAhead(secondaryInputIndex))
{
IThorDataLink *secondaryInput = queryInput(secondaryInputIndex);
Expand Down
13 changes: 9 additions & 4 deletions thorlcr/activities/keyedjoin/thkeyedjoinslave.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2675,13 +2675,18 @@ class CKeyedJoinSlave : public CSlaveActivity, implements IJoinProcessor, implem
{
if (queryAbortSoon())
break;
OwnedConstThorRow lhsRow = inputStream->nextRow();
if (!lhsRow)
OwnedConstThorRow lhsRow;
{
groupStart = nullptr; // NB: only ever set if preserveGroups on
LookAheadTimer t(slaveTimerStats, timeActivities);

lhsRow.setown(inputStream->nextRow());
if (!lhsRow)
break;
{
groupStart = nullptr; // NB: only ever set if preserveGroups on
lhsRow.setown(inputStream->nextRow());
if (!lhsRow)
break;
}
}
Linked<CJoinGroup> jg;
if (helper->leftCanMatch(lhsRow))
Expand Down

0 comments on commit 7fd4503

Please sign in to comment.