Skip to content

Commit

Permalink
HPCC-26539 Problems with httpcall_* and soapcall_* test cases in clou…
Browse files Browse the repository at this point in the history
…d (Azure) environment.

Delete one-line '//version ...' lines because they contains targetIP=x.x.x.x
values and it prevents regression test engine to pass the proper, configured
one.

Delete '//class=spray' tag from:
- httpcall_jsonpost.ecl
- httpcall_xmlpost.ecl

Add missing 'stored('targetIP)' into some tests to enable the RTE pass the
correct value.

Add correct 'targetIP' values into ecl-test-azure.json.

Add missing copyright header where missing.

Tested manually in AKS.

Signed-off-by: AttilaVamos <[email protected]>
  • Loading branch information
AttilaVamos committed Sep 21, 2023
1 parent 5f388e5 commit 7928e0f
Show file tree
Hide file tree
Showing 8 changed files with 85 additions and 16 deletions.
12 changes: 8 additions & 4 deletions testing/regress/ecl-test-azure.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,14 @@
],
"Params":[
"PassTest.ecl:bla='A value'",
"httpcall_multiheader.ecl:TargetIP=40.88.243.151",
"httpcall_jsonpost.ecl:targetIP=52.226.177.210",
"httpcall_xmlpost.ecl:targetIP=52.226.177.210",
"soapcall_multihttpheader.ecl:TargetIP=40.88.243.151"
"httpcall_multiheader.ecl:TargetIP=eclwatch",
"httpcall_jsonpost.ecl:targetIP=roxie",
"httpcall_xmlpost.ecl:targetIP=roxie",
"soapcall_multihttpheader.ecl:TargetIP=eclwatch",
"soapcall.ecl:targetIP=roxie",
"roxiegzip.ecl:TargetIP=roxie",
"roxiewhitespace.ecl:TargetIP=roxie",
"roxiepipe.ecl:TargetIP=roxie"
],
"engineParams":[
"failOnLeaks",
Expand Down
2 changes: 0 additions & 2 deletions testing/regress/ecl/httpcall_jsonpost.ecl
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@
limitations under the License.
############################################################################## */

//class=spray
//nothor
//nohthor

//class=roxieserviceaccess
//version targetIP='127.0.0.1',goodPort='9876',blacListedPort='9875'

#option('generateGlobalId', true);

Expand Down
2 changes: 0 additions & 2 deletions testing/regress/ecl/httpcall_xmlpost.ecl
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@
limitations under the License.
############################################################################## */

//class=spray
//nothor
//nohthor

//class=roxieserviceaccess
//version targetIP='127.0.0.1',goodPort='9876',blacListedPort='9875'

#option('generateGlobalId', true);

Expand Down
23 changes: 20 additions & 3 deletions testing/regress/ecl/roxiegzip.ecl
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
/*##############################################################################
HPCC SYSTEMS software Copyright (C) 2023 HPCC Systems®.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
############################################################################## */

//nothor
//nohthor

string TargetIP := '.' : stored('TargetIP');
string TargetURL := 'http://' + TargetIP + ':9876';

NameRec := RECORD
string First;
string Last;
Expand Down Expand Up @@ -72,9 +92,6 @@ roxieEchoTestResponseRecord doFail() := TRANSFORM
self.Exception.Source := 'Test';
END;

string TargetIP := '.' : stored('TargetIP');
string TargetURL := 'http://' + TargetIP + ':9876';

gzipResult := SOAPCALL(TargetURL, 'roxie_echo', roxieEchoTestRequestRecord,
DATASET(roxieEchoTestResponseRecord),
LITERAL,
Expand Down
21 changes: 20 additions & 1 deletion testing/regress/ecl/roxiepipe.ecl
Original file line number Diff line number Diff line change
@@ -1,6 +1,25 @@
/*##############################################################################
HPCC SYSTEMS software Copyright (C) 2012 HPCC Systems®.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
############################################################################## */

//nothor
//nohthor

string TargetIP := '.' : stored('TargetIP');

NameRec := RECORD
string10 First;
string15 Last;
Expand Down Expand Up @@ -49,7 +68,7 @@ pipe_recv := PIPE(pipe_send,
' -ow ' + SIZEOF(PersonRec) +
' -b 3' +
' -mr 2' +
' -h .:9876 ' +
' -h ' + TargetIP + ':9876 ' +
' -r Peeps' +
' -q "<roxie_echo format=\'raw\'><peeps id=\'id\' format=\'raw\'></peeps></roxie_echo>"'
, PersonRec);
Expand Down
23 changes: 20 additions & 3 deletions testing/regress/ecl/roxiewhitespace.ecl
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
/*##############################################################################
HPCC SYSTEMS software Copyright (C) 2023 HPCC Systems®.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
############################################################################## */

//nothor
//nohthor

string TargetIP := '.' : stored('TargetIP');
string TargetURL := 'http://' + TargetIP + ':9876';

NameRec := RECORD
string First;
string Last;
Expand Down Expand Up @@ -46,9 +66,6 @@ roxieEchoTestResponseRecord doFail() := TRANSFORM
self.Exception.Source := 'Test';
END;

string TargetIP := '.' : stored('TargetIP');
string TargetURL := 'http://' + TargetIP + ':9876';

soapcallResult := SOAPCALL(TargetURL, 'roxie_keepwhitespace', roxieEchoTestRequestRecord,
DATASET(roxieEchoTestResponseRecord),
LITERAL,
Expand Down
1 change: 0 additions & 1 deletion testing/regress/ecl/soapcall.ecl
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
############################################################################## */

//class=roxieserviceaccess
//version targetIP='127.0.0.1',goodPort='9876',blacListedPort='9875'

#option('generateGlobalId', true);

Expand Down
17 changes: 17 additions & 0 deletions testing/regress/ecl/soapcall_multihttpheader.ecl
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
/*##############################################################################
HPCC SYSTEMS software Copyright (C) 2023 HPCC Systems®.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
############################################################################## */

string TargetIP := '.' : stored('TargetIP');
string storedHeader := 'StoredHeaderDefault' : stored('storedHeader');

Expand Down

0 comments on commit 7928e0f

Please sign in to comment.