HPCC-32826 Avoid integer underflow when calculating elapsed cycles

Signed-off-by: Gavin Halliday <[email protected]>
hpcc-systems · Oct 18, 2024 · 76ae51a · 76ae51a
1 parent 6131e81
commit 76ae51a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/system/include/platform.h b/system/include/platform.h
@@ -492,7 +492,7 @@ typedef unsigned __int64 hash64_t;
 typedef unsigned __int64 __uint64;
 typedef __uint64 offset_t;
 typedef unsigned char byte;
-typedef __int64 cycle_t;
+typedef __uint64 cycle_t;                 // This must be unsigned to avoid integer overflow issues when subtracting
 typedef unsigned __int64 timestamp_type;
 
 // BUILD_TAG not needed here anymore - defined in build_tag.h

diff --git a/system/jlib/jdebug.cpp b/system/jlib/jdebug.cpp
@@ -483,8 +483,8 @@ class TimeSectionInfo : public MappingBase
     unsigned getCount() const { return count; }
 
     StringAttr  scope;
-    __int64 totalcycles;
-    __int64 maxcycles;
+    cycle_t totalcycles;
+    cycle_t maxcycles;
     unsigned count;
 };