Skip to content

Commit

Permalink
HPCC-32961 OwnedSpanScope re-assignment causes early span end
Browse files Browse the repository at this point in the history
- Deleted operators that could potentially cause issues

Signed-off-by: James McMullan [email protected]
  • Loading branch information
jpmcmu committed Dec 3, 2024
1 parent 128b9d0 commit 5dc75dd
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions system/jlib/jtrace.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,17 @@ class jlib_decl OwnedSpanScope
public:
OwnedSpanScope() = default;
OwnedSpanScope(ISpan * _ptr);
OwnedSpanScope(const OwnedSpanScope& rhs) = delete;
OwnedSpanScope(OwnedSpanScope&& rhs) = default;
~OwnedSpanScope();

inline ISpan * operator -> () const { return span; }
inline operator ISpan *() const { return span; }

inline OwnedSpanScope& operator=(ISpan * ptr) = delete;
inline OwnedSpanScope& operator=(const OwnedSpanScope& rhs) = delete;
inline OwnedSpanScope& operator=(OwnedSpanScope&& rhs) = delete;

void clear();
ISpan * query() const { return span; }
void set(ISpan * _span);
Expand Down

0 comments on commit 5dc75dd

Please sign in to comment.