HPCC-32439 Make all warnings into errors in Roxie subdirectory

Additional fixes that only show in release builds or Windows Signed-off-by: Richard Chapman <[email protected]>
hpcc-systems · Sep 25, 2024 · 5ac58a5 · 5ac58a5
1 parent 72bf456
commit 5ac58a5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/roxie/udplib/udpmsgpk.cpp b/roxie/udplib/udpmsgpk.cpp
@@ -68,7 +68,9 @@ class PackageSequencer : public CInterface, implements IInterface
     unsigned headerSize;
     const RoxiePacketHeader *header;
     unsigned maxSeqSeen = 0;
+#ifdef _DEBUG
     unsigned numPackets = 0;
+#endif
     bool outOfBand = false;
 
     MemoryBuffer metadata;
@@ -219,7 +221,7 @@ class PackageSequencer : public CInterface, implements IInterface
                 unsigned pktseq = fingerHdr->pktSeq & UDP_PACKET_SEQUENCE_MASK;
                 if (pktseq == prevseq+1)
                 {
-                    unsigned packetDataSize = fingerHdr->length - fingerHdr->metalength - sizeof(UdpPacketHeader);
+                    [[maybe_unused]] unsigned packetDataSize = fingerHdr->length - fingerHdr->metalength - sizeof(UdpPacketHeader);
                     assert(packetDataSize < roxiemem::DATA_ALIGNMENT_SIZE);
                     if (pktseq == 0)
                     {

diff --git a/roxie/udplib/udpsim.cpp b/roxie/udplib/udpsim.cpp
@@ -248,7 +248,7 @@ static unsigned completedThreads = 0;
 
 void simulateTraffic()
 {
-    const unsigned maxSendQueueSize = 100;
+    unsigned maxSendQueueSize = 100;
     try
     {
         myNode.setIp(IpAddress("1.2.3.4"));
@@ -258,7 +258,7 @@ void simulateTraffic()
         unsigned begin = msTick();
         std::atomic<unsigned> workValue{0};
 
-        asyncFor(numThreads+1, numThreads+1, [&workValue, &rm, &mc, &rowManager](unsigned i)
+        asyncFor(numThreads+1, numThreads+1, [&workValue, &rm, &mc, &rowManager, maxSendQueueSize](unsigned i)
         {
             if (!i)
             {