Merge pull request #18579 from jackdelv/HPCC-30681

HPCC-30681 Coverity scan unreachable code in Parquet plugin Reviewed-By: Dan S. Camper <[email protected]> Merged-by: Gavin Halliday <[email protected]>
hpcc-systems · Apr 26, 2024 · 3a14040 · 3a14040
2 parents d5c4ef2 + a4f941d
commit 3a14040
Showing 1 changed file with 0 additions and 9 deletions.
diff --git a/plugins/parquet/parquetembed.cpp b/plugins/parquet/parquetembed.cpp
@@ -1964,7 +1964,6 @@ ParquetEmbedFunctionContext::ParquetEmbedFunctionContext(const IContextLogger &_
 bool ParquetEmbedFunctionContext::getBooleanResult()
 {
     UNIMPLEMENTED_X("Parquet Scalar Return Type BOOLEAN");
-    return false;
 }
 
 void ParquetEmbedFunctionContext::getDataResult(size32_t &len, void *&result)
@@ -1975,19 +1974,16 @@ void ParquetEmbedFunctionContext::getDataResult(size32_t &len, void *&result)
 double ParquetEmbedFunctionContext::getRealResult()
 {
     UNIMPLEMENTED_X("Parquet Scalar Return Type REAL");
-    return 0.0;
 }
 
 __int64 ParquetEmbedFunctionContext::getSignedResult()
 {
     UNIMPLEMENTED_X("Parquet Scalar Return Type SIGNED");
-    return 0;
 }
 
 unsigned __int64 ParquetEmbedFunctionContext::getUnsignedResult()
 {
     UNIMPLEMENTED_X("Parquet Scalar Return Type UNSIGNED");
-    return 0;
 }
 
 void ParquetEmbedFunctionContext::getStringResult(size32_t &chars, char *&result)
@@ -2039,7 +2035,6 @@ byte *ParquetEmbedFunctionContext::getRowResult(IEngineRowAllocator *_resultAllo
 size32_t ParquetEmbedFunctionContext::getTransformResult(ARowBuilder &rowBuilder)
 {
     UNIMPLEMENTED_X("Parquet Transform Result");
-    return 0;
 }
 
 /**
@@ -2232,18 +2227,14 @@ class ParquetEmbedContext : public CInterfaceOf<IEmbedContext>
     virtual IEmbedFunctionContext *createFunctionContextEx(ICodeContext *ctx, const IThorActivityContext *activityCtx, unsigned flags, const char *options) override
     {
         if (flags & EFimport)
-        {
             UNSUPPORTED("IMPORT");
-            return nullptr;
-        }
         else
             return new ParquetEmbedFunctionContext(ctx ? ctx->queryContextLogger() : queryDummyContextLogger(), activityCtx, options, flags);
     }
 
     virtual IEmbedServiceContext *createServiceContext(const char *service, unsigned flags, const char *options) override
     {
         throwUnexpected();
-        return nullptr;
     }
 };