Skip to content

Commit

Permalink
Merge pull request #17801 from hpcc-systems/rpastrana-patch-2
Browse files Browse the repository at this point in the history
HPCC-30324 Addresses Win build issue
  • Loading branch information
GordonSmith authored Sep 22, 2023
2 parents 67d816c + 9a0866a commit 2ea1897
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions system/jlib/jtrace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -623,12 +623,12 @@ class CTraceManager : implements ITraceManager, public CInterface

if (!exportType.isEmpty())
{
if (strcasecmp(exportType.str(), "OS")==0) //To stdout/err
if (stricmp(exportType.str(), "OS")==0) //To stdout/err
{
exporter = opentelemetry::exporter::trace::OStreamSpanExporterFactory::Create();
DBGLOG("Tracing to stdout/err...");
}
else if (strcasecmp(exportType.str(), "OTLP")==0)
else if (stricmp(exportType.str(), "OTLP")==0)
{
namespace otlp = opentelemetry::exporter::otlp;

Expand All @@ -649,9 +649,9 @@ class CTraceManager : implements ITraceManager, public CInterface
exporter = otlp::OtlpGrpcExporterFactory::Create(opts);
DBGLOG("Tracing to OTLP (%s)", endPoint.str());
}
else if (strcasecmp(exportType.str(), "Prometheus")==0)
else if (stricmp(exportType.str(), "Prometheus")==0)
DBGLOG("Tracing to Prometheus currently not supported");
else if (strcasecmp(exportType.str(), "HPCC")==0)
else if (stricmp(exportType.str(), "HPCC")==0)
DBGLOG("Tracing to HPCC JLog currently not supported");
}
else
Expand Down Expand Up @@ -841,4 +841,4 @@ void initTraceManager(const char * componentName, IPropertyTree * config)
ITraceManager & queryTraceManager()
{
return *theTraceManager.query([] () { return new CTraceManager; }); //throws if not initialized
}
}

0 comments on commit 2ea1897

Please sign in to comment.