Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shardformer] support TP+DP for shardformer/ support DDP in HybridPlugin #4428

Closed

Conversation

Fridge003
Copy link
Contributor

@Fridge003 Fridge003 commented Aug 14, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

closed #4422

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

  • Support tp+dp for shardformer models, where dp is optimized using ddp
  • Add relevant tests

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@Fridge003 Fridge003 changed the title [shardformer] add tp+dp tests [shardformer] support tp+dp Aug 14, 2023
@Fridge003 Fridge003 force-pushed the feature/pipeline branch 2 times, most recently from 4eff4a8 to 53efc07 Compare August 14, 2023 09:16
@Fridge003 Fridge003 changed the title [shardformer] support tp+dp [shardformer] Support TP+DP / DDP Aug 14, 2023
@Fridge003 Fridge003 changed the title [shardformer] Support TP+DP / DDP [shardformer] support TP+DP for shardformer/ support DDP in HybridPlugin Aug 14, 2023
@Fridge003 Fridge003 closed this Aug 16, 2023
@Fridge003 Fridge003 deleted the feature/pipeline branch August 16, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant