Changes to proc/file ops to handle kernel 5.6 series #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjelmn
reviewed
Jun 23, 2020
kernel/xpmem_misc.c
Outdated
| .read = seq_read, | ||
| .write = xpmem_debug_printk_procfs_write, | ||
| .llseek = seq_lseek, | ||
| .open = xpmem_debug_printk_procfs_open, | ||
| .open = xpmem_debug_printk_procfs_open, | ||
| .release = single_release, |
There was a problem hiding this comment.
The .open member appears to be set twice here.
hjelmn
reviewed
Jun 23, 2020
| struct file_operations xpmem_debug_printk_procfs_ops = { | ||
| struct file_operations xpmem_debug_printk_procfs_ops = { | ||
| .owner = THIS_MODULE, | ||
| .owner = THIS_MODULE, |
hjelmn
reviewed
Jun 23, 2020
| .open = xpmem_unpin_procfs_open, | ||
| .release = single_release, | ||
| .release = single_release, | ||
| }; |
There was a problem hiding this comment.
Looks like a merge issue. I don't think this will compile with 5.5.x and older.
Fix typos in procfs_ops
…> lock, and declaration of "flush_tlb_mm_range" (need to investigate that one when 5.8 stabilizes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel interface changed file_ops to proc_ops