-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ran actions asynchronously with ActiveJob rather than Houston.async #140
Open
boblail
wants to merge
53
commits into
0.9-dev
Choose a base branch
from
activejob
base: 0.9-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can override module routes (1m)
…ations that don’t set an expiration (5m)
…ions rather than UI, and added the ability to revoke an authorization (1.5h) Tying authorizations makes it easier to see who added an authorization and who has the ability to delete it; and affords creating multiple authorizations between Houston and a given Provider — for different accounts. Defining Providers via extensions rather than UI keeps Client secrets out of the database, and allows modules to name providers and declare their dependance on authorizations to a certain provider. Adding “My Authorizations” allows users to always be able to see their own authorizations and revoke them.
…e and callback (10m)
The former “Role” concept modeled multiple roles but is no longer used except to model the concept of a “follower”. The new, simpler, model replaces it.
…ston.async` (20m) This has three benefits: 1. The Active Job Async adapter runs jobs in a thread pool. 2. It’s now much easier to move to using a backend like Sidekiq instead of threads. 3. Leveraging Active Job allows Houston instances to choose the right backend for them. # Conflicts: # app/models/action.rb
boblail
changed the title
Ran actions asynchronously with ActiveJob rather than
Ran actions asynchronously with ActiveJob rather Houston.async
Mar 7, 2017
Houston.async
boblail
changed the title
Ran actions asynchronously with ActiveJob rather Houston.async
Ran actions asynchronously with ActiveJob rather than Houston.async
Mar 7, 2017
boblail
force-pushed
the
0.9-dev
branch
2 times, most recently
from
March 30, 2017 00:45
c4992b5
to
1c04023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has three benefits: