-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip] When not browser focused on a view that refreshes, don’t refresh #139
base: 0.9-dev
Are you sure you want to change the base?
Conversation
… can override module routes (1m)
…ations that don’t set an expiration (5m)
…ions rather than UI, and added the ability to revoke an authorization (1.5h) Tying authorizations makes it easier to see who added an authorization and who has the ability to delete it; and affords creating multiple authorizations between Houston and a given Provider — for different accounts. Defining Providers via extensions rather than UI keeps Client secrets out of the database, and allows modules to name providers and declare their dependance on authorizations to a certain provider. Adding “My Authorizations” allows users to always be able to see their own authorizations and revoke them.
…e and callback (10m)
The former “Role” concept modeled multiple roles but is no longer used except to model the concept of a “follower”. The new, simpler, model replaces it.
…sh (5m) This would halt the ticker when you’re not currently looking at a view that does polling. Regaing focus calls the given callback and restarts the view.
Luke, do you think this'll mess up the dashboards? — like if one of those error messages shows up that we can't click on — or if they never have keyboard focus, they'll just not work? What do you think of this? Here's how the Alerts Dashboard uses the Refresher: new Refresher()
// ...
.callback(function() {
$.get('/alerts/dashboard' + window.location.search, {limit: limit}).done(renderAlerts);
}).render(); What if the Refresher supported an option where: if
Clients of We would then modify the Alerts Dashboard to opt-in to this feature like so: new Refresher()
// ...
.callback(function() {
- $.get('/alerts/dashboard' + window.location.search, {limit: limit}).done(renderAlerts);
+ return $.get('/alerts/dashboard' + window.location.search, {limit: limit}).done(renderAlerts);
}).render(); |
c4992b5
to
1c04023
Compare
This would halt the ticker when you’re not currently looking at a view that does polling. Regaining focus calls the given callback and restarts the view.
If you don't think this is a good idea or needs improvement, just comment on this. Thanks