-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added collapsable menu in navbar #26
base: master
Are you sure you want to change the base?
Conversation
@CHIRAG137 the deployment cannot be built since, according to the deployment logs, the build image is still being deployed on Ubuntu 16.04, which is unsupported. We might have to update the version. |
@SrijanSriv, I would suggest redeploying the repo using houseofgeeks official Gmail Account. Ping Yash in case you need credentials for it. |
redeployment it is then. thanks @tusharjain0022 |
i did a redploy as of now. would be good idea to host it with houseofgeek email. |
thanks a lot @ankiiitraj 🙌! While we get a proper redeployment of the front-end, @CHIRAG137 if you can check for any warnings present in your fork then that would be great. Check the above log to verify |
@SrijanSriv I have resolved all the issues and warnings. Kindly review them. |
Hi @CHIRAG137 please use react-bootstrap and not just plane bootstrap. I'll, however, suggest not using bootstrap at all, it is very heavy and overkill for a simple project like this. On top of this using bootstrap is killing all the good parts of react, if you see every link clicks is reloading the page. |
@CHIRAG137 while we are accepting this pr under hacktoberfest, it will be a good idea to keep the app an SPA. The least you can try is adding react-bootstrap. Of course the package doesnt include it already, and adding it sounds like too much as @ankiiitraj mentioned. Still, its okay to try for now if you're confused. |
@SrijanSriv yes, I am trying to get this issue resolved. |
fixes #25
Description: The title should be short and relevant.
Checklist
Testimonial