Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added collapsable menu in navbar #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CHIRAG137
Copy link

@CHIRAG137 CHIRAG137 commented Oct 12, 2022

fixes #25

Description: The title should be short and relevant.

Checklist

  • I've followed the Contributing guidelines provided in the repository.
  • I've made the changes which were demanded in the linked issue.
  • I've tested my code on a Chromium based browser.
  • I've tested my code on Mozilla Firefox.
  • My code gave a clean console on debugging. (no warnings/errors)

Testimonial

@SrijanSriv
Copy link
Member

@CHIRAG137 the deployment cannot be built since, according to the deployment logs, the build image is still being deployed on Ubuntu 16.04, which is unsupported. We might have to update the version.
Unfortunately, I dont have the access to the deployment.
cc: @ankiiitraj @tusharjain0022

@tusharjain0022
Copy link
Member

@SrijanSriv, I would suggest redeploying the repo using houseofgeeks official Gmail Account. Ping Yash in case you need credentials for it.

@SrijanSriv
Copy link
Member

redeployment it is then. thanks @tusharjain0022
i believe @EricLiclair has the required credentials

@ankiiitraj
Copy link
Member

i did a redploy as of now. would be good idea to host it with houseofgeek email.

@ankiiitraj
Copy link
Member

@SrijanSriv
Copy link
Member

thanks a lot @ankiiitraj 🙌! While we get a proper redeployment of the front-end, @CHIRAG137 if you can check for any warnings present in your fork then that would be great. Check the above log to verify

@CHIRAG137
Copy link
Author

@SrijanSriv I have resolved all the issues and warnings. Kindly review them.

@ankiiitraj
Copy link
Member

Hi @CHIRAG137 please use react-bootstrap and not just plane bootstrap. I'll, however, suggest not using bootstrap at all, it is very heavy and overkill for a simple project like this.

On top of this using bootstrap is killing all the good parts of react, if you see every link clicks is reloading the page.

@SrijanSriv
Copy link
Member

@CHIRAG137 while we are accepting this pr under hacktoberfest, it will be a good idea to keep the app an SPA. The least you can try is adding react-bootstrap. Of course the package doesnt include it already, and adding it sounds like too much as @ankiiitraj mentioned. Still, its okay to try for now if you're confused.
The deployment has also been done on hG's official team. Cheers!

@CHIRAG137
Copy link
Author

@SrijanSriv yes, I am trying to get this issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Collapsable Menu in the navbar
4 participants