Customize isHTML url pattern not only "htm|html|xhtml|php" #789

xiaohui-zhangxh · 2022-11-05T05:36:43Z

I think this pattern can not only assume .htm, .html, .xhtml, .php is a HTML page, but also .jsp, .asp, .whatever ...

export function isHTML(url: URL) {
  return !!getExtension(url).match(/^(?:|\.(?:htm|html|xhtml|php))$/)
}

I found this issue when I'm integrating monaco-editor to edit source code online, url looks like http://tanmer.lvh.me:3000/themes/-/ide/theme/1/edit/version/1/-/assets/cart-drawer.js , this URL is not a javascript, it's a HTML page to edit cart-drawer.js

With this PR, I can customize my own pattern to identify HTML page:

  <head>
    <meta name="turbo-html-url-pattern" content="\/-\/ide\/theme\/\d+\/edit\/version/\d+\/-\/"/>
  <./head>

…tern'

brunoprietog · 2024-12-13T13:44:25Z

Addressed in #1230

customize isHTML url regular expression from meta 'turbo-html-url-pat…

0e0a170

…tern'

brunoprietog closed this Dec 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Customize isHTML url pattern not only "htm|html|xhtml|php" #789

Customize isHTML url pattern not only "htm|html|xhtml|php" #789

xiaohui-zhangxh commented Nov 5, 2022 •

edited

Loading

brunoprietog commented Dec 13, 2024

Customize isHTML url pattern not only "htm|html|xhtml|php" #789

Customize isHTML url pattern not only "htm|html|xhtml|php" #789

Conversation

xiaohui-zhangxh commented Nov 5, 2022 • edited Loading

brunoprietog commented Dec 13, 2024

xiaohui-zhangxh commented Nov 5, 2022 •

edited

Loading