Export StreamActions as property of window.Turbo

[afcapel]

This was removed in #1049 but it's still used in the turbo-rails test suite.

https://github.com/hotwired/turbo-rails/blob/c3ca7009c0759563ec65ecf1bc60a9af1ff33728/test/system/broadcasts_test.rb#L137

@seanpdoyle can you have a look, please?

[brunoprietog]

Thanks! I've upgraded to beta and can confirm that custom actions are not working. Turbo.StreamActions is undefined

[seanpdoyle]

The exports should be equivalent between the reverted change and this one. I'm not sure why this is necessary.

There's existing test coverage introduced prior to this change that guarantees Turbo.StreamActions is exported.

I was unsure of whether or not the export test was sufficient, so I experimented with adding more specific coverage locally. The following tests passed when executed on main:

diff --git a/src/tests/unit/export_tests.js b/src/tests/unit/export_tests.js
index 7b7ddf3..e3e06cc 100644
--- a/src/tests/unit/export_tests.js
+++ b/src/tests/unit/export_tests.js
@@ -3,7 +3,6 @@ import * as Turbo from "../../"
 import { StreamActions } from "../../"
 
 test("Turbo interface", () => {
-  assert.equal(typeof Turbo.StreamActions, "object")
   assert.equal(typeof Turbo.start, "function")
   assert.equal(typeof Turbo.registerAdapter, "function")
   assert.equal(typeof Turbo.visit, "function")
@@ -20,6 +19,28 @@ test("Turbo interface", () => {
   assert.equal(typeof Turbo.session, "object")
 })
 
+test("Turbo.StreamActions interface", () => {
+  assert.equal(Turbo.StreamActions, StreamActions)
+  assert.equal(typeof Turbo.StreamActions, "object")
+  assert.equal(typeof Turbo.StreamActions.after, "function")
+  assert.equal(typeof Turbo.StreamActions.append, "function")
+  assert.equal(typeof Turbo.StreamActions.before, "function")
+  assert.equal(typeof Turbo.StreamActions.prepend, "function")
+  assert.equal(typeof Turbo.StreamActions.remove, "function")
+  assert.equal(typeof Turbo.StreamActions.replace, "function")
+  assert.equal(typeof Turbo.StreamActions.update, "function")
+  assert.equal(typeof Turbo.StreamActions.refresh, "function")
+})
+
 test("StreamActions interface", () => {
+  assert.equal(StreamActions, Turbo.StreamActions)
   assert.equal(typeof StreamActions, "object")
+  assert.equal(typeof StreamActions.after, "function")
+  assert.equal(typeof StreamActions.append, "function")
+  assert.equal(typeof StreamActions.before, "function")
+  assert.equal(typeof StreamActions.prepend, "function")
+  assert.equal(typeof StreamActions.remove, "function")
+  assert.equal(typeof StreamActions.replace, "function")
+  assert.equal(typeof StreamActions.update, "function")
+  assert.equal(typeof StreamActions.refresh, "function")
 })

[jorgemanrubia]

Thanks @afcapel

[afcapel]

@seanpdoyle I think what is happening is that StreamActions is being exported as part of the module, but not set up inside window.Turbo. It's a bit confusing, but what we set as window.Turbo here is just the exports of core/index.js, not the whole Turbo module.

The unit tests pass because the asserting the exports from the module, not the global window.Turbo. I've added some browser tests to check window.Turbo as well.