Integrate [data-turbo-temporary] with pagehide event
#1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
close-1030
branch
from
b4044df to
ade7ee5
Compare
Closes hotwired#1030 Add a [pagehide][] listener to the `CacheObserver` class to listen for when the page has potential to enter the browser's [Back-Forward Cache][bcfache]. When the event is dispatched with the [persisted][] set to `true`, remove all temporary elements. [pagehide]: https://developer.mozilla.org/en-US/docs/Web/API/Window/pagehide_event [bfcache]: https://web.dev/articles/bfcache#observe_when_a_page_is_entering_bfcache [persisted]: https://developer.mozilla.org/en-US/docs/Web/API/PageTransitionEvent/persisted
seanpdoyle
force-pushed
the
close-1030
branch
from
ade7ee5 to
04221a9
Compare
|
The suite is passing for Chrome, but failing for Firefox. I'm not sure how to proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1030
Add a pagehide listener to the
CacheObserverclass to listen for when the page has potential to enter the browser's Back-Forward Cache.When the event is dispatched with the persisted set to
true, remove all temporary elements.