Upgrade all packages (#551)

* upgrade all dependencies * cast unknown error as Error * add skipLibCheck to tsconfig We only have devDeps so no need to check them * upgrade typescript to latest * set intern CHROMEDRIVER version Pins Intern chromedriver to the one available in actions Refs theintern/intern#1159 Co-authored-by: Kristján Oddsson <[email protected]> Co-authored-by: Kristján Oddsson <[email protected]>
hotwired · Mar 30, 2022 · 5ed3dc1 · 5ed3dc1
1 parent d2b7ec5
commit 5ed3dc1
Show file tree

Hide file tree

Showing 5 changed files with 1,533 additions and 1,528 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -20,6 +20,15 @@ jobs:
     - run: yarn install
     - run: yarn build
 
+    - name: Set Chrome Version
+      run: |
+        CHROMEVER="$(chromedriver --version | cut -d' ' -f2)"
+        echo "Actions ChromeDriver is $CHROMEVER"
+        CONTENTS="$(jq '.tunnelOptions.drivers[0].name = "chrome"' < intern.json)"
+        CONTENTS="$(echo ${CONTENTS} | jq --arg chromever "$CHROMEVER" '.tunnelOptions.drivers[0].version = $chromever')"
+        echo "${CONTENTS}" > intern.json
+        cat intern.json
+
     - name: Test
       run: yarn test
 

diff --git a/package.json b/package.json
@@ -35,15 +35,15 @@
     "access": "public"
   },
   "devDependencies": {
-    "@rollup/plugin-node-resolve": "9.0.0",
-    "@rollup/plugin-typescript": "^6.0.0",
+    "@rollup/plugin-node-resolve": "13.1.3",
+    "@rollup/plugin-typescript": "8.3.1",
     "@types/multer": "^1.4.5",
+    "arg": "^5.0.1",
     "intern": "^4.9.0",
-    "arg": "^4.1.0",
     "multer": "^1.4.2",
     "rollup": "^2.35.1",
     "tslib": "^2.0.3",
-    "typescript": "^4.1.3"
+    "typescript": "^4.6.3"
   },
   "scripts": {
     "clean": "rm -fr dist",

diff --git a/src/http/fetch_request.ts b/src/http/fetch_request.ts
@@ -86,8 +86,8 @@ export class FetchRequest {
       const response = await fetch(this.url.href, fetchOptions)
       return await this.receive(response)
     } catch (error) {
-      if (error.name !== 'AbortError') {
-        this.delegate.requestErrored(this, error)
+      if ((error as Error).name !== 'AbortError') {
+        this.delegate.requestErrored(this, (error as Error))
         throw error
       }
     } finally {

diff --git a/tsconfig.json b/tsconfig.json
@@ -10,6 +10,7 @@
     "target": "es2017",
     "noEmit": true,
     "removeComments": true,
+    "skipLibCheck": true,
   },
   "exclude": [ "dist", "src/tests/fixtures" ]
 }