Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto basemap generation if tms url is input during project creation #2027

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

Anuj-Gupta4
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

  • Added extra option to tile source of BasemapGenerate pydantic model.
  • Added tms basemap generation during project data generation if tms url was present during project creation.

@Anuj-Gupta4 Anuj-Gupta4 force-pushed the feat/auto-basemap-generation branch from 0b2987c to f12facc Compare December 25, 2024 08:48
@Anuj-Gupta4 Anuj-Gupta4 changed the title Feat/auto basemap generation Auto basemap generation if tms url is input during project creation Dec 25, 2024
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to have in place πŸ˜„

In theory this should add minimal time to the project file creation API response time.

So the frontend will redirect and the project can be viewed. The basemap generation will lock a thread, but there should generally be another thread available to serve the project response afterwards.

This will have more guarantees in future with a separate basemap-api microservice though

src/backend/app/projects/project_routes.py Show resolved Hide resolved
@Sujanadh Sujanadh merged commit 6d7aa55 into hotosm:development Dec 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code enhancement New feature or request
Projects
None yet
3 participants