-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement user invitation functionality for projects via OSM messages #2019
Merged
Sujanadh
merged 3 commits into
hotosm:development
from
Anuj-Gupta4:feat/invite-new-user
Dec 30, 2024
Merged
Implement user invitation functionality for projects via OSM messages #2019
Sujanadh
merged 3 commits into
hotosm:development
from
Anuj-Gupta4:feat/invite-new-user
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or request
backend
Related to backend code
labels
Dec 23, 2024
Anuj-Gupta4
had a problem deploying
to
2019/merge
December 23, 2024 09:48 — with
GitHub Actions
Failure
Anuj-Gupta4
had a problem deploying
to
2019/merge
December 23, 2024 10:04 — with
GitHub Actions
Failure
Anuj-Gupta4
changed the title
feat: implement user invitation functionality for projects via OSM messages
Implement user invitation functionality for projects via OSM messages
Dec 25, 2024
Anuj-Gupta4
had a problem deploying
to
2019/merge
December 26, 2024 03:54 — with
GitHub Actions
Failure
Sujanadh
approved these changes
Dec 26, 2024
Anuj-Gupta4
force-pushed
the
feat/invite-new-user
branch
from
December 26, 2024 05:33
a877e00
to
5efc949
Compare
spwoodcock
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect π
What I'm thinking for the future to make this flow better for the org admin invite too:
- A new db table for invites, including invite tokens, and selected permissions
- We have a new endpoint to accept invites
- We create tokens (with an expiry) to access this endpoint
- The OSM endpoint includes a link that calls this API (which includes the token)
- Calling the endpoint with the specific token first logs in the user, so the db has an entry for them
- Then we add the specified user roles to the db too (org or project permissions)
Open to other ideas though!
This sounds like a great idea. |
Sujanadh
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Related to backend code
docs
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
Added an endpoint that will take a project id and username, check if an osm user with such username exists and then sends them an invite with a link to the project.
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?