-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mapping.md #2012
base: development
Are you sure you want to change the base?
Update mapping.md #2012
Conversation
documented updating of users metadata in osm. Signed-off-by: Manjita Pandey <[email protected]>
for more information, see https://pre-commit.ci
docs/manuals/mapping.md
Outdated
mapping experience. | ||
|
||
## Part (A): Setup For Mapping | ||
|
||
### Step 1: Install The Custom ODK Collect Mobile App | ||
|
||
- The first time you load the project, you should be prompted to download | ||
the custom `.apk` from the sidebar. | ||
the custom `.apk` from the upper right corner of your browser window | ||
usually represented by three vertical dots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not dot
. It shall be represented by a hamburger menu(might be technical)/menu/β°
updated changes requested Signed-off-by: Manjita Pandey <[email protected]>
Love the changes π The stuff regarding adding these three metadata fields doesn't have to be done byvthr user though. They are automatically injected field by us & are always collected (username, email, device id) |
I observed we don't add email and phone numbers automatically but usernames are added and I have provided them info about that too. |
@@ -19,7 +23,19 @@ mapping experience. | |||
You may have to enable installing from unknown sources in your device | |||
settings too. | |||
|
|||
### Step 2: Access the Mapper Frontend | |||
### Step 2: Add metadata on odk application(Optional) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section should be removed, as its not something the user should have to configure manually. All the fields you mention are already included by default.
Sure we don't actually inject an email or phoje number into the field yet (as they are not available, we may never do this), but they are enabled anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is only to inform the users that if their project needs email address, phone number or any other metadata that we don't have, they don't need to fill up in every form rather they can use this method. Otherwise its not compulsory and completely optional behavior for them.
However, some projects need their user's phone number to contact them if needed. In such cases, they can add it in instruction and this document can help was my point of view. Hope that makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we have no ability to configure this with the current code: the fields are always enabled by default. Perhaps this would make sense if we added the config option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm misunderstanding this, as I have never tested the approach you mention
documented updating of users metadata in osm.
What type of PR is this? (check all applicable)
Related Issue
Example: Fixes #2010 , #921
Describe this PR
Added more details on mapper's workflow
Addition of user's metadata in odk
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?