Feature/hgi 6873 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new stream, ReviewsStream, to the Klaviyo integration. The ReviewsStream is defined with its own name, path, primary keys, and replication key, allowing for the extraction of review data from the Klaviyo API. This enhances the data extraction capabilities of the tap.
- Updated the HTTP headers revision date in KlaviyoStream to "2024-10-15". - Introduced methods for loading schemas and filling missing properties in KlaviyoStream, improving schema handling. - Added a new ReviewsStream with updated replication key and URL parameterization for pagination. - Created a new JSON schema file for reviews, defining the structure and required properties for review data. These changes improve the functionality and robustness of the Klaviyo integration, enabling better data extraction and schema management.
butkeraites-hotglue
force-pushed
the
feature/hgi-6873
branch
from
8ea6c6d to
771930e
Compare
hsyyid
reviewed
Dec 2, 2024
| def load_schema(self, name): | ||
| return json.load(open(self.get_abs_path('schemas/{}.json'.format(name)))) | ||
|
|
||
| def _fill_missing_properties(self, property_list): |
There was a problem hiding this comment.
It gets from a schema file a list of default properties to complement the dynamic discover
hsyyid
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.