Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread safety ( guard against collection has changed errors) #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OracPrime
Copy link

Upside: there won't be an error is something is logged whilst someone is enumerating the results of (e.g.) RecordedLogs.

Downside: it has to make a copy of the list. However it's only the list object that will be duplicated, the actual tuples in the list won't be.

@OracPrime
Copy link
Author

I believe the above failures are a permissions issue related to the fact that I triggered the change, rather than horsdal.

@OracPrime
Copy link
Author

The two commits are entirely independent, although I recommend you take both :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant