SideCI Demo Pull Request #1
Conversation
| private | ||
|
|
||
| def repository | ||
| client.repository full_name |
There was a problem hiding this comment.
[RuboCop]
Layout/ExtraSpacing: Unnecessary spacing detected.
| end | ||
|
|
||
| def releases | ||
| repository&.releases.map(&:name) |
There was a problem hiding this comment.
[RuboCop]
Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.
| private | ||
|
|
||
| def repository | ||
| client.repository full_name |
There was a problem hiding this comment.
[RuboCop]
Layout/SpaceBeforeFirstArg: Put one space between the method name and the first argument.
| end | ||
|
|
||
| def active_branch | ||
| repository.branches.max { |a, b| a.updated_at <=> b.updated_at } |
There was a problem hiding this comment.
[RuboCop]
Performance/CompareWithBlock: Use max_by(&:updated_at) instead of max { |a, b| a.updated_at <=> b.updated_at }.
| private $public; | ||
| private $branches; | ||
|
|
||
| const PublicVisibility = 'public'; |
There was a problem hiding this comment.
[PHPMD]
Constant PublicVisibility should be defined in uppercase
| * @param string $name | ||
| * @param string $visibility | ||
| */ | ||
| public function Repository(string $owner, string $name, string $visibility) |
There was a problem hiding this comment.
[PHPMD]
Repository accesses the super-global variable $_SERVER.
| * @param string $name | ||
| * @param string $visibility | ||
| */ | ||
| public function Repository(string $owner, string $name, string $visibility) |
There was a problem hiding this comment.
[PHPMD]
Classes should not have a constructor method with the same name as the class
| private $owner; | ||
| private $name; | ||
| private $public; | ||
| private $branches; |
There was a problem hiding this comment.
[PHPMD]
Avoid unused private fields such as '$branches'.
| /** | ||
| * @return bool | ||
| */ | ||
| public function getPublic(): bool |
There was a problem hiding this comment.
[PHPMD]
The 'getPublic()' method which returns a boolean should be named 'is...()' or 'has...()'
Welcome to SideCI!