[DRAFT] - Borrow page: Health lvl #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BowTiedHeron
requested changes
Dec 9, 2022
|
|
||
| const { formatPercent: fp, formatERC20: fs } = formatNumber; | ||
| const Markets: NextPage = () => { | ||
| const COLLATERAL_FACTOR = 0.65; |
There was a problem hiding this comment.
we should not use hard coded values. for EVM we can get this from the contracts.
There was a problem hiding this comment.
Oke, we should call upon the contract and extract the value there
| @@ -2,6 +2,8 @@ import React, { FC } from 'react'; | |||
| import * as style from './HealthLvl.css'; | |||
| import { HealthLvlProps, HealthLvlPoint } from './types'; | |||
|
|
|||
| // const { formatPercent: fp } = formatNumber; | |||
| const { currentUser, setCurrentUser } = useContext(UserContext); | ||
| const [tableData, setTableData] = useState<MarketTableRow[]>([]); | ||
| const [isMyCollectionsFilterEnabled, setIsMyCollectionsFilterEnabled] = useState(false); | ||
| const [expandedRowKeys, setExpandedRowKeys] = useState<readonly antdKey[]>([]); | ||
| const { toast, ToastComponent } = useToast(); |
There was a problem hiding this comment.
seems unrelated, please create an issue for new found bugs
There was a problem hiding this comment.
it's not, we need it in the useEffect otherwise can't integrate the loader - see commit below
| const { currentUser, setCurrentUser } = useContext(UserContext); | ||
| const [tableData, setTableData] = useState<MarketTableRow[]>([]); | ||
| const [isMyCollectionsFilterEnabled, setIsMyCollectionsFilterEnabled] = useState(false); | ||
| const [expandedRowKeys, setExpandedRowKeys] = useState<readonly antdKey[]>([]); | ||
| const { toast, ToastComponent } = useToast(); | ||
| const NFTId = useLoanFlowStore((state) => state.NFTId); |
There was a problem hiding this comment.
it's not, we need it in the useEffect otherwise can't integrate the loader - see commit below. Also used for the call of borrowamount
BowTiedHeron
changed the title
BowTiedHeron
changed the title
BowTiedHeron
force-pushed
the
final-style-fixes
branch
from
c5c3253 to
4071333
Compare
BowTiedHeron
deleted the
67-borrow-page-re-introduce-health-lvl-and-make-sure-the-calc-works
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated the health percentage component in the borrow page - please review.