feat: Double down on abbreviation style. #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdow
approved these changes
May 31, 2024
Comment on lines
8
to
11
| ofv: "visible", | ||
| ofh: "hidden", | ||
| ofs: "scroll", | ||
| ofa: "auto", |
There was a problem hiding this comment.
If I'm being a real stickler, then overflow -> of doesn't exactly follow the conventions, right? That'd expect "overFlow" -> of. I'd be okay with ov, oh, os, etc.
Comment on lines
+6
to
+8
| tdn: "none", | ||
| tdlt: "line-through", | ||
| tdu: "underline", |
There was a problem hiding this comment.
I like these changes as it's closer to the CSS property names.
stephenh
commented
May 31, 2024
| vaBl: "baseline", | ||
| vam: "middle", | ||
| vat: "top", | ||
| vaBm: "bottom", |
There was a problem hiding this comment.
@bdow wdyt of this vaBm vs. vaBottom? Usually when we have "two vabs", we spell out vaBottom vs. vaBaseline, but was thinking maybe this would be cute...
There was a problem hiding this comment.
I'm indifferent, but would lean towards spelling it out. Feels more clear that way.
homebound-team-bot
pushed a commit
that referenced
this pull request
May 31, 2024
# [1.135.0](v1.134.0...v1.135.0) (2024-05-31) ### Features * Double down on abbreviation style. ([#121](#121)) ([6b28580](6b28580))
|
🎉 This PR is included in version 1.135.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.