Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flex-wrap styles #118

Merged
merged 1 commit into from
Dec 6, 2023
Merged

feat: Add flex-wrap styles #118

merged 1 commit into from
Dec 6, 2023

Conversation

bdow
Copy link

@bdow bdow commented Dec 6, 2023

No description provided.

return this.add("flexWrap", "nowrap");
}
/** Sets `flexWrap: value`. */
flexWrap(value: Properties["flexWrap"]) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to use fw as the key, though that is already used by font-weight.

Copy link
Contributor

@stephenh stephenh Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for flexWrap.

Wdyt about fwWrap -> fww, fwReverse -> fwr, fwNoWrap -> fwnw? Thinking they'd probably not overlap with the existing fw variants...

I think that pattern of fooBar: fizz-buzz -> fbfb has been generally what our abbreviations have been moving towards recently.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!

Copy link
Contributor

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just saw flexWrap typed out in some code yesterday and was like gah need that in truss! :-D

@bdow bdow merged commit 698070c into main Dec 6, 2023
2 checks passed
@bdow bdow deleted the flex-wrap branch December 6, 2023 16:04
homebound-team-bot pushed a commit that referenced this pull request Dec 6, 2023
# [1.132.0](v1.131.1...v1.132.0) (2023-12-06)

### Features

* Add flex-wrap styles ([#118](#118)) ([698070c](698070c))
@homebound-team-bot
Copy link

🎉 This PR is included in version 1.132.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants