feat: Require init.input or init.query. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had several auto-saving form-states not realize they should use
init.input + map to get the latest data from the mutation response
automatically included in the form.
In general, having `init: T` is a legacy/rare use case, so let's try
removing it.
Callers that were doing `init: data` can now do `init { input: data }`
although technically the `init.input` will pull in changes to `data`
as its identity changes, while `init: data` would not.
If we roll this out and find a lot of places that need that `init: data`
behavior, we could add something like:
```
init: {
input: data,
initOnlyOnce: true,
}
```
Or something like that, to be more explicit that they're requesting
to not re-read the `input: data` value on each re-render.
stephenh
commented
Dec 8, 2023
| * The opts has for `useFormState`. | ||
| * | ||
| * @typeparam T the form type, which is usually as close as possible to your *GraphQL input* | ||
| * @typeparam I the *form input* type, which is usually the *GraphQL output* type, i.e. the type of the response from your GraphQL query |
There was a problem hiding this comment.
@TylerR909 per your request. Fwiw I acknowledge the "form input type is the graphql output type" and "graphql input type is the form type" is awkward, but it seems to fundamentally step from:
- GraphQL output type ==> form "input" ==> form "output" ==> GraphQL input
Open to better ways of naming/articulating this.
homebound-team-bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
## [2.24.0](v2.23.2...v2.24.0) (2023-12-15) ### Features * Require init.input or init.query. ([#104](#104)) ([2e97582](2e97582))
|
🎉 This PR is included in version 2.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had several auto-saving form-states not realize they should use init.input + map to get the latest data from the mutation response automatically included in the form.
In general, having
init: Tis a legacy/rare use case, so let's try removing it.Callers that were doing
init: datacan now doinit { input: data }although technically theinit.inputwill pull in changes todataas its identity changes, whileinit: datawould not.If we roll this out and find a lot of places that need that
init: databehavior, we could add something like:Or something like that, to be more explicit that they're requesting to not re-read the
input: datavalue on each re-render.