feat: Add more overloads for SelectField options. #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getOptionValue` is not necessary for options with ids or codes. `getOptionLabel` is not necessary for options with name, displayName, or labels.
stephenh
force-pushed
the
add-more-overloads
branch
from
2b9d512 to
d8c118c
Compare
TylerR909
approved these changes
Feb 5, 2024
Comment on lines
+124
to
+125
| { code: AuthorHeight.SHORT, name: "Shortish" }, | ||
| { code: AuthorHeight.TALL, name: "Tallish" }, |
| } | ||
|
|
||
| export function defaultOptionLabel<O>(opt: O): any { | ||
| if (typeof opt !== "object" || !opt) fail(`Option ${opt} has no id or code`); |
There was a problem hiding this comment.
hmm... how destructive would it be to allow strings. Like, I'd like to be able to do
options={["One", "Two", "Three"]}
// or
options={Object.values(SomeEnum)}
where ID/Val would be the same. Seems unnecessary to map an Enum over to an Object just for the sake of this. But, I'm sure a lot of infra expects an Object so makes sense it would be rough to support.
There was a problem hiding this comment.
Yeah, that's a fair ask. Will think about it...
homebound-team-bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
## [2.335.0](v2.334.3...v2.335.0) (2024-02-05) ### Features * Add more overloads for SelectField options. ([#999](#999)) ([0663afe](0663afe))
|
🎉 This PR is included in version 2.335.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getOptionValueis now optional foroptionswith ids or codes.getOptionLabelis now optional foroptionswith name, displayName, or labels.