fix: Fix Switch not toggling. #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
commented
Dec 15, 2023
|
|
||
| return ( | ||
| <div | ||
| <label |
There was a problem hiding this comment.
A previous styling change changed this top-level element from a label to a div, but that seems to have broken the input-flips-to-true/false because the input isn't wrapped in a label anymore.
This is a little janky b/c we now have two labels in this component, but the tests/stories show that this fixes the regression, so I'm prioritizing getting the fix out vs. a perfect DOM structure that doesn't have duplicate labels.
homebound-team-bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
## [2.331.1](v2.331.0...v2.331.1) (2023-12-15) ### Bug Fixes * Fix Switch not toggling. ([#985](#985)) ([e2a06bd](e2a06bd))
|
🎉 This PR is included in version 2.331.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.