feat: Support 'fullWidth' prop on all text fields #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
reviewed
Dec 6, 2023
| @@ -90,6 +90,8 @@ export function ComboBoxInput<O, V extends Value>(props: ComboBoxInputProps<O, V | |||
| const multilineProps = allowWrap ? { textAreaMinHeight: 0, multiline: true } : {}; | |||
| useGrowingTextField({ disabled: !allowWrap, inputRef, inputWrapRef, value: inputProps.value }); | |||
|
|
|||
| console.log("otherProps", otherProps); | |||
stephenh
approved these changes
Dec 6, 2023
No, |
stephenh
approved these changes
Dec 6, 2023
bdow
force-pushed
the
full-width-text-field
branch
from
3ddc8eb to
a2b9fe2
Compare
homebound-team-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
## [2.327.0](v2.326.1...v2.327.0) (2023-12-07) ### Features * Support 'fullWidth' prop on all text fields ([#979](#979)) ([6bf26ac](6bf26ac))
|
🎉 This PR is included in version 2.327.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a
PresentationFieldProps.fullWidthproperty. The following components will respect the property:Updates the
FormLinescomponent to default to the"lg"size instead of"full". This will hopefully minimize the impact on existing layouts as the previous default width for each field withinFormLineswas 550px. By using thelgsize, we'll continue to default the fields withinFormLinesto 550px.