feat: add inModal state on useModal #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allangaldinosilva
requested review from
stephenh,
bdow,
ksk5280 and
chr1sjf0x
as code owners
bdow
reviewed
Nov 28, 2023
bdow
approved these changes
Dec 1, 2023
homebound-team-bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
## [2.326.0](v2.325.2...v2.326.0) (2023-12-01) ### Features * add inModal state on useModal ([#974](#974)) ([8f8ca2e](8f8ca2e))
|
🎉 This PR is included in version 2.326.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new state,
isModalOpen, to theuseModalhook to track the open/closed state of a modal in a page.It will initially be used on Search Query improvements addressed on this PR https://github.com/homebound-team/internal-frontend/pull/4385
From my tests, it did not trigger unnecessary re-renders for other components.
cc @bdow / @stephenh