feat: add modal prop to force modal interaction; #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apattersonATX-HB
requested review from
stephenh,
ksk5280 and
chr1sjf0x
as code owners
stephenh
approved these changes
Nov 6, 2024
src/components/Modal/Modal.tsx
Outdated
| * Relies on you to provide a way to close the modal, i.e. a cancel or confirm button. | ||
| * Useful if you definitely need to force the user to make a choice. | ||
| * */ | ||
| forceModalInteraction?: boolean; |
There was a problem hiding this comment.
Thought: I think my first guess at naming this would have been allowClosing (defaults true, users can set it to false)... Maybe still a slight preference for that, but not totally against forceModalInteraction; wdyt?
There was a problem hiding this comment.
Names are hard, and i cant come up with anything better 🙃 Will update to allowClosing
homebound-team-bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
## [2.370.0](v2.369.7...v2.370.0) (2024-11-06) ### Features * add modal prop to force modal interaction; ([#1085](#1085)) ([3d6617f](3d6617f)), closes [/github.com/homebound-team/internal-frontend/compare/main...sc-60329/schedules-merge-draft-view#diff-3e5dd94f92d2a5b4d5e1e0b362d7d8e2d9ec52af58eb9cfd833a0e195d56ed3](https://github.com/homebound-team//github.com/homebound-team/internal-frontend/compare/main...sc-60329/schedules-merge-draft-view/issues/diff-3e5dd94f92d2a5b4d5e1e0b362d7d8e2d9ec52af58eb9cfd833a0e195d56ed3) [/github.com/homebound-team/internal-frontend/compare/main...sc-60329/schedules-merge-draft-view#diff-832d5b6b2b80a4d541fbe0eb1a55eaf856777b136a6f2e4540880035f544be87R82](https://github.com/homebound-team//github.com/homebound-team/internal-frontend/compare/main...sc-60329/schedules-merge-draft-view/issues/diff-832d5b6b2b80a4d541fbe0eb1a55eaf856777b136a6f2e4540880035f544be87R82)
|
🎉 This PR is included in version 2.370.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orchestration has been asked to combine the dynamic schedule draft mode with the standard view. The draft pages were built as individual routes using a shared store to pass task changes between them. In combining these pages, we need to warn users their changes will be lost before allowing them to navigate away. Since we're using a shared store and not just a shared form I want to update Blueprints
<NavigationContext />navigationCheckCallbacksto support more robust nav checks. I've gotten that working, but since the inner<NavigationPrompt />fromreact-router-navigation-promptpasses its own callback when a cancel action happens, routing breaks if a user clicks outside of our modal or closes with thexicon since the NavigationPrompt inner onCancel callback is never called.Context (branch is WIP):
TLDR: Needed a way to force users to interact with the modal.
Screen.Recording.2024-11-06.at.11.39.31.AM.mov