feat: Auto call onAddNew when the user searchs and there is no match #1070
Conversation
JonnCharpentier
requested review from
stephenh,
bdow,
ksk5280 and
chr1sjf0x
as code owners
JonnCharpentier
changed the title
JonnCharpentier
force-pushed
the
sc-56770-auto-add
branch
from
83c0c8a to
7f8f211
Compare
| useEffect(() => { | ||
| if (!debouncedSearch || !onAddNew) return; | ||
| if (filteredOptions.length === 1 && filteredOptions[0] === addNewOption) onAddNew(debouncedSearch); | ||
| }, [debouncedSearch, filteredOptions, onAddNew]); |
There was a problem hiding this comment.
thought: This feels like we're assuming too much. It's possible the user has a typo, or just wants to see what options are available. They may not want to go straight to the Add New callback.
question: Is this coming from product feedback?
There was a problem hiding this comment.
Agree with you, feels too much. But also the user can hit ESC or the x icon to go back to select mode
This was an ask from Dave.
There was a problem hiding this comment.
So if I have a typo, then I'll automatically move to the "Add new" text field. I'll try to hit backspace to fix my input, but then I'm no longer in the select field. As a user I'll have to understand that not matching anything in the list will automatically change my field. And then know that I can return to the list by the two methods you described.
I don't think that is going to be clear to our users.
I disagree with the purposed UX and I think it's going to make for a poor user experience. If this is really want Dave wants and thinks that it is the correct thing, then let's push it through.
There was a problem hiding this comment.
I'll talk to Dave about it
JonnCharpentier
force-pushed
the
sc-56770-auto-add
branch
from
7f8f211 to
d647544
Compare
This change allow us to automatically switch to
Add modewhen the user search and there are not matches in the provided options