feat: SC-47184: Add new icons #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #47184: Add new icons for Task Catalog. |
kbesingeryeh
requested review from
stephenh,
bdow,
ksk5280 and
chr1sjf0x
as code owners
bdow
approved these changes
Feb 22, 2024
src/components/Icon.tsx
Outdated
| circleOutline: ( | ||
| <path | ||
| d="M12 2C6.486 2 2 6.486 2 12C2.001 17.515 6.487 22.001 12 22.001C17.514 22.001 22 17.515 22.001 12C22.001 6.486 17.515 2 12 2ZM12 20.001C7.59 20.001 4.001 16.412 4 12C4 7.589 7.589 4 12 4C16.412 4 20.001 7.589 20.001 12C20 16.412 16.411 20.001 12 20.001Z" | ||
| fill="#484848" |
There was a problem hiding this comment.
suggestion: Typically we do not define the fill property in each path. Maybe we should remove, unless we really want it hard coded.
There was a problem hiding this comment.
got it. I have removed!
homebound-team-bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
## [2.336.0](v2.335.2...v2.336.0) (2024-02-23) ### Features * SC-47184: Add new icons ([#1004](#1004)) ([d8ee5f5](d8ee5f5))
|
🎉 This PR is included in version 2.336.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new icons from Figma: https://app.shortcut.com/homebound-team/story/47184/add-new-icons-for-task-catalog