Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format NetworkManager connection name correctly for VLANs #4986

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

agners
Copy link
Member

@agners agners commented Mar 27, 2024

Proposed change

Make sure NetworkManager connections are named correctly for VLANs as well (.).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Make sure NetworkManager connections are named correctly for VLANs
as well (<interface-name>.<vlan-id>).
@agners agners added the bugfix A bug fix label Mar 27, 2024
@agners agners merged commit a9265af into main Apr 2, 2024
19 checks passed
@agners agners deleted the format-vlan-interface-name-corrrectly branch April 2, 2024 19:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants