Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor widget sizes #3187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Penait1
Copy link
Contributor

@Penait1 Penait1 commented Nov 23, 2024

Summary

Add bigger widget sizes for the sensors widget

Screenshots

Screenshot 2024-11-23 at 14 14 59 Screenshot 2024-11-23 at 14 19 06

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.07%. Comparing base (6c34210) to head (1933d34).
Report is 364 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3187       +/-   ##
===========================================
+ Coverage   27.54%   47.07%   +19.52%     
===========================================
  Files         311      200      -111     
  Lines       31699    12227    -19472     
===========================================
- Hits         8733     5756     -2977     
+ Misses      22966     6471    -16495     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bgoncal
Copy link
Member

bgoncal commented Nov 24, 2024

Looks good to me, have you tried bigger sizes? Like for macOS? If you run the widgets target for mac there is a nice widgets simulator

@Penait1
Copy link
Contributor Author

Penait1 commented Nov 24, 2024

Mm there seems to be some wonky stuff happening at certain amount of models.
It is also happening with the open page widget. With certain amount of selected items (4, 11, 12 and 16 I tested) they will be off the screen like this. With 20 they are fine
Screenshot 2024-11-24 at 15 52 42

I think I will remove the extraLarge and investigate how it can be fixed since the non sensor view also seems to have issues

Edit: it seems to happen too with the large widget and 7 items I think I need to do some more investigating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants