Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancels page retry loop with negative intervals. #22983

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

RubenNL
Copy link
Contributor

@RubenNL RubenNL commented Nov 24, 2024

Proposed change

Cancels the "retry" interval when reload takes longer than expected.

This shouldn't be required, but sometimes, which I can't easily reproduce, it gets in a reload loop, but cancels the reload every second.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

This shouldn't be required, but sometimes, which I can't easily reproduce, it fails to reload.
Fixes home-assistant#20052
src/layouts/ha-init-page.ts Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 25, 2024 06:28
@RubenNL RubenNL marked this pull request as ready for review November 25, 2024 11:59
@bramkragten bramkragten enabled auto-merge (squash) November 25, 2024 12:09
@bramkragten bramkragten merged commit a525c44 into home-assistant:dev Nov 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reboot -> "Retrying in -[MINUS] [NUMBER] Secounds | Wrong Language
3 participants