Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addons picker in generate backup dialog #22951

Merged
merged 11 commits into from
Nov 22, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Nov 21, 2024

Proposed change

Basic support for add-ons selection.
I will look to refactor the ha-backup-data-picker to use ha-backup-addons-picker in another PR.
Also ha-backup-addons-picker needs to be updated to use the same style as ha-backup-addons-picker

Looks like the addons are not really in the backup after the creation. I will check with core team.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya marked this pull request as draft November 21, 2024 21:24
@piitaya piitaya marked this pull request as ready for review November 22, 2024 09:45
@piitaya piitaya force-pushed the addons_picker_generate_backup branch from 9cda54f to 6c3bd32 Compare November 22, 2024 09:57
@bramkragten bramkragten merged commit 760cae2 into allthebackupchanges Nov 22, 2024
4 checks passed
@bramkragten bramkragten deleted the addons_picker_generate_backup branch November 22, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants