Improve explanation of response variables #22920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an action does return a result the user can save this in a variable that can be used in the next actions in the sequence. That variable is created by simply naming it in the action. This should be made clearer in the two strings that describe this option. By using "… name for a variable …" becomes inherently clear that this variable will be created by the action.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
NoRi2909
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an action does return a result the user can save this in a variable that can be used in the next actions in the sequence.
That variable is created by simply naming it in the action.
This should be made clearer in the two strings that describe this option.
By using "… name for a variable …" becomes inherently clear that this variable will be created by the action.
I'm not sure if it is that obvious in English, but in German "… der Name einer Variable …" implies that it already exists under that name, while " … der Name für eine Variable …" implies that it will be created with that specified name. That's where the main motivation for the PR comes from.
Proposed change
Change "of" to "for a variable" in both strings.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: