Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset select-selector to undefined when cleared #20821

Merged
merged 1 commit into from
May 18, 2024

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented May 18, 2024

Proposed change

When clicking the clear button on a clearable select-selector, reset the value to undefined instead of "", as this better matches the initial state.

With the current implementation, in the template helper form if we pick a device class, and then clear it, the select field gets angry as "" is not one of the valid options. As the field is optional it should be clearable back to the initial state without a validation error.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @karwosts 👍

../Frenck

@frenck frenck merged commit 914dbc1 into home-assistant:dev May 18, 2024
14 checks passed
@karwosts karwosts deleted the clear-select-selector branch May 18, 2024 15:54
@karwosts karwosts mentioned this pull request May 26, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants