Minor improvements to service call descriptions. #20733
Conversation
src/translations/en.json
Outdated
| "service_based_on_template": "Call a service based on a template{hasTargets, select, \n true { on {targets}} \n other {} \n }", | ||
| "service_based_on_name": "Call a service ''{name}''{hasTargets, select, \n true { on {targets}} \n other {} \n }", | ||
| "service_name": "{domain} ''{name}''{hasTargets, select, \n true { on {targets}} \n other {} \n }", |
There was a problem hiding this comment.
Should we split each translation in two keys to simplify translator work?
There was a problem hiding this comment.
We've already got dozens of keys using a similar pattern. Should I consider {select} as always discouraged? Having two translations for the same sentence seems cluttery, and this does not seem exceptionally complex, but I will follow guidance if we have some.
There was a problem hiding this comment.
I've introduced many of these, and the general feedback from those pull requests was to split the sentence when there were multiple selects, nested selects or it became pretty long in number of characters.
If it's really needed, I would suggest to introduce keys for when no target exists, so the existing translations don't need to be translated.
There was a problem hiding this comment.
Yes, agreed, it saves missing translations (old ones would need to get updated) and makes it a bit easier for translators (although I'm surprised how well it goes actually!)
Proposed change
Two small changes:
dataiftargetis not defined, for services that don't use the target picker.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: