-
-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ClimateEntity for horizontal swing support #2309
Open
gjohansson-ST
wants to merge
2
commits into
master
Choose a base branch
from
climate-horizontal-swing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
--- | ||
author: G Johansson | ||
authorURL: https://github.com/gjohansson-ST | ||
authorImageURL: https://avatars.githubusercontent.com/u/62932417?v=4 | ||
authorTwitter: GJohansson | ||
title: "Climate entity now supports independent horizontal swing" | ||
--- | ||
|
||
As of Home Assistant Core 2024.10, we have implemented an independent property and method for controling horizontal swing in `ClimateEntity`. | ||
|
||
Integrations that supports completely independent control and state for vertical and horizontal swing can now use the previous `swing_mode` for vertical support only and use the new `swing_horizontal_mode` for providing the horizontal vane state. | ||
|
||
Integrations that don't have independent control should still keep using the current `swing_mode` for both vertical and horizontal support. | ||
|
||
|
||
### Example | ||
|
||
Example requirements to implement `swing` and `swing_horizontal` in your climate entity. | ||
|
||
```python | ||
|
||
class MyClimateEntity(ClimateEntity): | ||
"""Implementation of my climate entity.""" | ||
|
||
@property | ||
def supported_features(self) -> ClimateEntityFeature: | ||
"""Return the list of supported features.""" | ||
return ClimateEntityFeature.SWING_MODE | ClimateEntityFeature.SWING_HORIZONTAL_MODE | ||
|
||
@property | ||
def swing_mode(self) -> str | None: | ||
"""Return the swing setting. | ||
|
||
Requires ClimateEntityFeature.SWING_MODE. | ||
""" | ||
return self._attr_swing_mode | ||
|
||
@property | ||
def swing_modes(self) -> list[str] | None: | ||
"""Return the list of available swing modes. | ||
|
||
Requires ClimateEntityFeature.SWING_MODE. | ||
""" | ||
return self._attr_swing_modes | ||
|
||
@property | ||
def swing_mode(self) -> str | None: | ||
"""Return the swing setting. | ||
|
||
Requires ClimateEntityFeature.SWING_HORIZONTAL_MODE. | ||
""" | ||
return self._attr_swing_horizontal_mode | ||
|
||
@property | ||
def swing_modes(self) -> list[str] | None: | ||
"""Return the list of available swing modes. | ||
|
||
Requires ClimateEntityFeature.SWING_HORIZONTAL_MODE. | ||
""" | ||
return self._attr_swing_horizontal_modes | ||
|
||
async def async_set_swing_mode(self, swing_mode: str) -> None: | ||
"""Set new target swing operation.""" | ||
await self.api.set_swing_mode(swing_mode) | ||
|
||
async def async_set_swing_horizontal_mode(self, swing_horizontal_mode: str) -> None: | ||
"""Set new target horizontal swing operation.""" | ||
await self.api.set_swing_horizontal_mode(swing_horizontal_mode) | ||
|
||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the grammatical error.
The sentence should be:
Integrations that support completely independent control and state for vertical and horizontal swing can now use the previous
swing_mode
for vertical support only and use the newswing_horizontal_mode
for providing the horizontal vane state.Committable suggestion
Tools
LanguageTool