Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powerfox integration #131640

Draft
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

klaasnicolaas
Copy link
Member

@klaasnicolaas klaasnicolaas commented Nov 26, 2024

Proposed change

This PR will add the Powerfox integration to get (currently only) your power and water meter data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck marked this pull request as draft November 26, 2024 17:48
@frenck
Copy link
Member

frenck commented Nov 26, 2024

Marked draft, as there are CI errors.

@klaasnicolaas klaasnicolaas marked this pull request as ready for review November 26, 2024 19:22
homeassistant/components/powerfox/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/powerfox/sensor.py Outdated Show resolved Hide resolved
"""Set up Powerfox sensors based on a config entry."""
entities: list[SensorEntity] = []
for coordinator in entry.runtime_data:
if isinstance(coordinator.data, PowerMeter):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have only one tuple with all entity descriptions (both water and power), could we simplify and remove this if/else here?

Copy link
Member Author

@klaasnicolaas klaasnicolaas Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if that is really an improvement, because then you go through the entire entity list per device (more if checks). The thing with the Powerfox API is that I only know what kind of device it is and which entities belong, after the response data return, hence the use of isinstance to make a distinction.

Will adjust and test it, although I find the current code more readable 🤔

./Klaas

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 27, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants